History
Version 201
at Tuesday 2 March 2010 16:56:56 UTC - Fixed #15: Execute ExcessivePublicCount rule.Diff
| 200 | 201 | /test/PHP/PMD/Regression/AllTests.php |
|---|---|---|
| 51 | 51 | |
| 52 | 52 | require_once dirname(__FILE__) . '/AcceptsFilesAndDirectoriesAsInputTicket001Test.php'; |
| 53 | 53 | require_once dirname(__FILE__) . '/InvalidUnusedLocalVariableAndFormalParameterTicket007Test.php'; |
| 54 | +require_once dirname(__FILE__) . '/ExcessivePublicCountRuleNeverExecutedTicket015Test.php'; | |
| 54 | 55 | |
| 55 | 56 | /** |
| 56 | 57 | * Main test suite for the PHP_PMD_Regression package. |
| 77 | 78 | |
| 78 | 79 | $suite->addTestSuite('PHP_PMD_Regression_AcceptsFilesAndDirectoriesAsInputTicket001Test'); |
| 79 | 80 | $suite->addTestSuite('PHP_PMD_Regression_InvalidUnusedLocalVariableAndFormalParameterTicket007Test'); |
| 81 | + $suite->addTestSuite('PHP_PMD_Regression_ExcessivePublicCountRuleNeverExecutedTicket015Test'); | |
| 80 | 82 | |
| 81 | 83 | return $suite; |
| 82 | 84 | } |
| 200 | 201 | /test/PHP/PMD/Rule/ExcessivePublicCountTest.php |
| 78 | 78 | $rule = new PHP_PMD_Rule_ExcessivePublicCount(); |
| 79 | 79 | $rule->setReport($this->getReportMock(0)); |
| 80 | 80 | $rule->addProperty('minimum', '42'); |
| 81 | - $rule->apply($this->getClassMock('nopm', 23)); | |
| 81 | + $rule->apply($this->getClassMock('cis', 23)); | |
| 82 | 82 | } |
| 83 | 83 | |
| 84 | 84 | /** |
| 94 | 94 | $rule = new PHP_PMD_Rule_ExcessivePublicCount(); |
| 95 | 95 | $rule->setReport($this->getReportMock(1)); |
| 96 | 96 | $rule->addProperty('minimum', '42'); |
| 97 | - $rule->apply($this->getClassMock('nopm', 42)); | |
| 97 | + $rule->apply($this->getClassMock('cis', 42)); | |
| 98 | 98 | } |
| 99 | 99 | |
| 100 | 100 | /** |
| 110 | 110 | $rule = new PHP_PMD_Rule_ExcessivePublicCount(); |
| 111 | 111 | $rule->setReport($this->getReportMock(1)); |
| 112 | 112 | $rule->addProperty('minimum', '23'); |
| 113 | - $rule->apply($this->getClassMock('nopm', 42)); | |
| 113 | + $rule->apply($this->getClassMock('cis', 42)); | |
| 114 | 114 | } |
| 115 | 115 | } |
| 200 | 201 | /source/PHP/PMD/Rule/ExcessivePublicCount.php |
| 64 | 64 | * @version Release: @package_version@ |
| 65 | 65 | * @link http://phpmd.org |
| 66 | 66 | */ |
| 67 | -class PHP_PMD_Rule_ExcessivePublicCount extends PHP_PMD_AbstractRule | |
| 67 | +class PHP_PMD_Rule_ExcessivePublicCount | |
| 68 | + extends PHP_PMD_AbstractRule | |
| 69 | + implements PHP_PMD_Rule_IClassAware | |
| 68 | 70 | { |
| 69 | 71 | /** |
| 70 | 72 | * This method checks the number of public fields and methods in the given |
| 76 | 78 | */ |
| 77 | 79 | public function apply(PHP_PMD_AbstractNode $node) |
| 78 | 80 | { |
| 79 | - if ($node->getMetric('nopm') < $this->getIntProperty('minimum')) { | |
| 81 | + if ($node->getMetric('cis') < $this->getIntProperty('minimum')) { | |
| 80 | 82 | return; |
| 81 | 83 | } |
| 82 | 84 | $this->addViolation($node); |